Hello Marco, On 7/30/20 11:13 PM, Marco Felsch wrote: > Hi, > > sorry for jumping in. No worries, > On 20-07-11 07:28, Ahmad Fatoum wrote: >> Ah, I thought the drvdata is pre-populated in Linux. I would rename >> the new function to device_get_match_data then for alignment with >> Linux, with the difference that it returns either platform data or >> device tree driver_data as appropriate. > > Linux uses the of_device_get_match_data() [1] for of-based drivers. > > [1] https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/of/device.c#L189 Yes, future barebox device_get_match_data should work with both of and platform data, that's why I'd drop the of_ prefix. Cheers, Ahmad > > Regards, > Marco > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
