On Thu, Jul 16, 2020 at 11:40:46AM +0200, Lucas Stach wrote:
> Am Donnerstag, den 16.07.2020, 08:46 +0200 schrieb Oleksij Rempel:
> > Calling the devinfo against a device which is linked to some devicetree
> > node weill result a devictree dump of this node. For example:
> >
> > barebox@Protonic PRTI6Q board:/ devinfo sound-spdif.of
> > Bus: platform
> > Device node: /sound-spdif
> > sound-spdif {
> > compatible = "fsl,imx-audio-spdif";
> > model = "imx-spdif";
> > spdif-controller = <0x7a>;
> > spdif-in;
> > spdif-out;
> > };
> >
> > Calling same command on a device wich is linked to the root node of
> > devicetree, for example "machine.of", will trigger a dump fo complete
> > devicetree.
>
> Taking a step back from the immediate issue with the root node: is it
> even a good idea to dump the whole subtree of nodes in the devinfo?
> Most likely someone using devinfo is only interested in the of_node of
> the device and maybe some subnodes that don't have a device on their
> own.
>
> So wouldn't it make more sense to only dump the node of the device in
> question and subnodes without a compatible? This way we could remove
> the special case for the root node and still get some useful
> information in devinfo, like the board compatible property.
Hm... i have nothing against it. Then probably it is better to exclude
this patch for now.
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
