Re: [PATCH] kbuild: add dtbs target for building all dtbs of an ARCH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 06, 2020 at 12:31:09AM +0200, Ahmad Fatoum wrote:
> 
> 
> On 7/5/20 7:35 PM, Sascha Hauer wrote:
> > On Thu, Jul 02, 2020 at 10:59:34AM +0200, Ahmad Fatoum wrote:
> >> As described in the documentation, upstream device trees extended by
> >> barebox should take care to cause compile errors, not runtime errors,
> >> when the paths they extend disappear. This way, breakage can be easily
> >> detected when synchronizing the dts/ directory and fixed right then.
> >>
> >> Make this process easier by providing a dtbs target that builds all
> >> device trees in arch/$(SRCARCH)/dts/ if available.
> >>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> >> ---
> >>  Makefile | 18 ++++++++++++++++++
> >>  1 file changed, 18 insertions(+)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index 0da032532712..9fa741966c00 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -990,6 +990,20 @@ include/generated/version.h: FORCE
> >>  include/generated/utsrelease.h: include/config/kernel.release FORCE
> >>  	$(call filechk,utsrelease.h)
> >>  
> >> +# ---------------------------------------------------------------------------
> >> +# Devicetree files
> >> +
> >> +ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/dts/),)
> >> +dtstree := arch/$(SRCARCH)/dts
> >> +endif
> >> +
> >> +ifneq ($(dtstree),)
> >> +
> >> +PHONY += dtbs
> >> +dtbs: $(patsubst $(srctree)/%.dts,$(objtree)/%.dtb,$(wildcard $(srctree)/$(dtstree)/*.dts))
> >> +
> >> +endif
> > 
> > Can we do this in a way that only rebuilds the changed files and not
> > every dts again?
> 
> Probably, I would have to check how though. But it doesn't matter that much IMO.
> Target is meant to be run only after dts/ update. It's not part of the normal
> development workflow.

Well, you could convince me that this is really hard to solve, then we
can talk about merging it like this. Otherwise I would really prefer
solving this proper.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux