Re: [PATCH 1/2] mfd: superio: smsc: fix C99ism initial declaration in for loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 02, 2020 at 03:29:18PM +0200, Ahmad Fatoum wrote:
> Codebase is meant to be gnu89, but was only enforced starting
> with bc4840e98b94 ("kbuild: add -Wmissing-prototypes and -std=gnu89
> to KBUILD_HOSTCFLAGS"). Since then, this driver no longer compiles.
> Fix this.
> 
> Fixes: eaf020f1bb52 ("mfd: superio: add base SMSC MFD driver")
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
>  drivers/mfd/smsc-superio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mfd/smsc-superio.c b/drivers/mfd/smsc-superio.c
> index 349c878cefe0..ff83aa1a4419 100644
> --- a/drivers/mfd/smsc-superio.c
> +++ b/drivers/mfd/smsc-superio.c
> @@ -106,8 +106,9 @@ static void smsc_superio_find(u16 sioaddr, u16 id_reg)
>  static int smsc_superio_detect(void)
>  {
>  	u16 ports[] = { 0x2e, 0x4e, 0x162e, 0x164e, 0x3f0, 0x370 };
> +	int i;
>  
> -	for (int i = 0; i < ARRAY_SIZE(ports); i++)
> +	for (i = 0; i < ARRAY_SIZE(ports); i++)
>  		smsc_superio_find(ports[i], SIO_REG_DEVID);
>  
>  	return 0;
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux