On Sat, Jun 06, 2020 at 07:13:04AM +0200, Oleksij Rempel wrote: > The dryrun in this function is used two times: > - with "Would run %s\n" and return > - to store dryrun for later use > > The second one makes no sense since the first one will abort execution. > Since it is needed for debugging any way, it is better to allow to abort > later, just before starting the OS. I think that we must abort before running the command, not afterwards. Originally it was thought that the bootscripts only configure the setup for a following bootm. Many bootscripts failed to do so and just start something right away, for these we indeed have to abort before running the command. You are right, this makes the second if(dryrun) pointless of course. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
