Re: [PATCH] treewide: replace commas with semicolons where appropriate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 18, 2020 at 11:31:35AM +0200, Roland Hieber wrote:
> On Sun, May 17, 2020 at 08:20:39PM +0200, Ahmad Fatoum wrote:
> > Found by searching drivers/ arch/ common/ and lib/ for
> > 
> >  /^\s+[^."/\*\[\s\{\(A-Z][^\[\{\(]*=[^\{\(]+,$/
> > 
> > Because the comma has the lowest precedence in C,
> > this shouldn't result in any functional change.
> > 
> > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> > ---
> >  .../boards/eukrea_cpuimx35/eukrea_cpuimx35.c  |  2 +-
> >  arch/arm/mach-imx/iim.c                       |  6 +++---
> >  arch/nios2/lib/libgcc.c                       | 21 ++++++++++---------
> >  drivers/i2c/busses/i2c-imx-early.c            |  2 +-
> >  drivers/i2c/busses/i2c-imx.c                  |  2 +-
> >  drivers/i2c/busses/i2c-omap.c                 |  2 +-
> >  drivers/mci/stm32_sdmmc2.c                    |  4 ++--
> >  drivers/net/usb/usbnet.c                      | 10 ++++-----
> >  8 files changed, 25 insertions(+), 24 deletions(-)
> > 
> > diff --git a/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c b/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c
> > index 220a484bde80..558bc0791243 100644
> > --- a/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c
> > +++ b/arch/arm/boards/eukrea_cpuimx35/eukrea_cpuimx35.c
> > @@ -242,7 +242,7 @@ static int eukrea_cpuimx35_core_init(void)
> >  	reg = writel(reg, MX35_CCM_BASE_ADDR + MX35_CCM_CGR0);
> >  	reg = readl(MX35_CCM_BASE_ADDR + MX35_CCM_CGR1);
> >  	reg |= 0x3 << MX35_CCM_CGR1_FEC_SHIFT;
> > -	reg |= 0x3 << MX35_CCM_CGR1_I2C1_SHIFT,
> > +	reg |= 0x3 << MX35_CCM_CGR1_I2C1_SHIFT;
> >  	reg = writel(reg, MX35_CCM_BASE_ADDR + MX35_CCM_CGR1);
> >  	reg = readl(MX35_CCM_BASE_ADDR + MX35_CCM_CGR2);
> >  	reg |= 0x3 << MX35_CCM_CGR2_USB_SHIFT;
> > diff --git a/arch/arm/mach-imx/iim.c b/arch/arm/mach-imx/iim.c
> > index 207e1879c3a9..2c7ffb009097 100644
> > --- a/arch/arm/mach-imx/iim.c
> > +++ b/arch/arm/mach-imx/iim.c
> > @@ -329,9 +329,9 @@ static int imx_iim_add_bank(struct iim_priv *iim, int num, int nregs)
> >  
> >  	iim->bank[num] = bank;
> >  
> > -	bank->map_config.reg_bits = 8,
> > -	bank->map_config.val_bits = 8,
> > -	bank->map_config.reg_stride = 1,
> > +	bank->map_config.reg_bits = 8;
> > +	bank->map_config.val_bits = 8;
> > +	bank->map_config.reg_stride = 1;
> >  	bank->map_config.max_register = (nregs - 1),
> 
> Your regex didn't spot this line :)

Changed and added to this patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux