On Sun, May 17, 2020 at 08:20:39PM +0200, Ahmad Fatoum wrote:
> Found by searching drivers/ arch/ common/ and lib/ for
>
> /^\s+[^."/\*\[\s\{\(A-Z][^\[\{\(]*=[^\{\(]+,$/
>
> Because the comma has the lowest precedence in C,
> this shouldn't result in any functional change.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> .../boards/eukrea_cpuimx35/eukrea_cpuimx35.c | 2 +-
> arch/arm/mach-imx/iim.c | 6 +++---
> arch/nios2/lib/libgcc.c | 21 ++++++++++---------
> drivers/i2c/busses/i2c-imx-early.c | 2 +-
> drivers/i2c/busses/i2c-imx.c | 2 +-
> drivers/i2c/busses/i2c-omap.c | 2 +-
> drivers/mci/stm32_sdmmc2.c | 4 ++--
> drivers/net/usb/usbnet.c | 10 ++++-----
> 8 files changed, 25 insertions(+), 24 deletions(-)
>
> diff --git a/arch/nios2/lib/libgcc.c b/arch/nios2/lib/libgcc.c
> index abf93fdd71d4..814df7331058 100644
> --- a/arch/nios2/lib/libgcc.c
> +++ b/arch/nios2/lib/libgcc.c
> @@ -319,15 +319,15 @@ DWtype __divdi3(DWtype u, DWtype v)
> DWunion vv = {.ll = v};
> DWtype w;
>
> - if (uu.s.high < 0)
> - c = ~c,
> -
> - uu.ll = -uu.ll;
> -
> - if (vv.s.high < 0)
> - c = ~c,
> + if (uu.s.high < 0) {
> + c = ~c;
> + uu.ll = -uu.ll;
> + }
>
> - vv.ll = -vv.ll;
> + if (vv.s.high < 0) {
> + c = ~c;
> + vv.ll = -vv.ll;
> + }
Indeed it looks like the code is correct, not the indention.
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
