On Sun, May 17, 2020 at 08:19:39PM +0200, Ahmad Fatoum wrote:
> A barebox environment oftree node may reference its storage by a phandle
> to a partition node under a MCI node. barebox will then call the
> device's detect method to detect the card if this hasn't happened
> before. Out of 17 MCI drivers, 8 host drivers already implement
> a detect method, which just calls mci_detect_card.
>
> Provide a generic implementation that does the same.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> Cc: Lucas Stach <lst@xxxxxxxxxxxxxx>
> ---
> drivers/mci/mci-core.c | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index e8844a3c0007..ab80c4d5ba5c 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1806,9 +1806,14 @@ int mci_detect_card(struct mci_host *host)
>
> static int mci_detect(struct device_d *dev)
> {
> - struct mci *mci = container_of(dev, struct mci, dev);
> + struct mci *mci;
> +
> + list_for_each_entry(mci, &mci_list, list) {
> + if (dev == &mci->dev || dev == mci->host->hw_dev)
> + return mci_detect_card(mci->host);
> + }
I think it would look better to keep the existing mci_detect function
and add a new mci_hw_detect which does the loop for the hw device only.
Otherwise I'm happy with this approach.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
