Re: [PATCH] kvx: do not include empty <config.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- On 15 May, 2020, at 17:22, Masahiro Yamada masahiroy@xxxxxxxxxx wrote:

> <config.h> is per-board config file, which is only allowed for old
> boards.
> 
> For new boards, the top Makefile creates an empty include/config.h
> 
> kvx does not have config.h, so #include <config.h> is useless.
> 
> Also, remove meaningless board-$(CONFIG_GENERIC).

Hi Masahiro,

Thanks for spotting that.

FWIW:
Acked-By: Clement Leger <cleger@xxxxxxxxx> 

Clément

> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
> 
> arch/kvx/Makefile          | 2 --
> arch/kvx/cpu/barebox.lds.S | 1 -
> arch/kvx/cpu/start.S       | 1 -
> 3 files changed, 4 deletions(-)
> 
> diff --git a/arch/kvx/Makefile b/arch/kvx/Makefile
> index c97cff345..7abaed651 100644
> --- a/arch/kvx/Makefile
> +++ b/arch/kvx/Makefile
> @@ -2,8 +2,6 @@ KBUILD_DEFCONFIG := generic_defconfig
> 
> KBUILD_CPPFLAGS += -fno-strict-aliasing
> 
> -board-$(CONFIG_GENERIC) := generic
> -
> KALLSYMS += --symbol-prefix=_
> 
> ifeq ($(CROSS_COMPILE),)
> diff --git a/arch/kvx/cpu/barebox.lds.S b/arch/kvx/cpu/barebox.lds.S
> index 8d1944afb..bf92564cf 100644
> --- a/arch/kvx/cpu/barebox.lds.S
> +++ b/arch/kvx/cpu/barebox.lds.S
> @@ -3,7 +3,6 @@
>  * Copyright (C) 2019 Kalray Inc.
>  */
> 
> -#include <config.h>
> #include <asm/common.h>
> #include <asm/sys_arch.h>
> #include <asm-generic/barebox.lds.h>
> diff --git a/arch/kvx/cpu/start.S b/arch/kvx/cpu/start.S
> index a02900fb9..d90272c71 100644
> --- a/arch/kvx/cpu/start.S
> +++ b/arch/kvx/cpu/start.S
> @@ -3,7 +3,6 @@
>  * Copyright (C) 2019 Kalray Inc.
>  */
> 
> -#include <config.h>
> #include <linux/linkage.h>
> #include <asm/privilege.h>
> #include <asm/sys_arch.h>
> --
> 2.25.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux