On Fri, May 08, 2020 at 08:01:00PM +0200, Daniel Glöckner wrote: > Hello Sascha, > > Am 22.04.20 um 09:54 schrieb Sascha Hauer: > > diff --git a/commands/Kconfig b/commands/Kconfig > > index 7fb47b8fb5..5ff6454427 100644 > > --- a/commands/Kconfig > > +++ b/commands/Kconfig > > @@ -269,6 +269,15 @@ config CMD_POLLER > > is_timeout() or one of the various delay functions. The poller command prints > > informations about registered pollers. > > > > +config CMD_SLICE > > + tristate > > + prompt "slice" > > + depends on SLICE > > + help > > + slices are a way to protect resources from being accessed by pollers. The slice > > + command can be used to print informations about slices and also to manipulate > > + them on the command line for debugging purposes. > > + > > # end Information commands > > endmenu > > > > diff --git a/common/Kconfig b/common/Kconfig > > index 400c0553cf..bd2aebac75 100644 > > --- a/common/Kconfig > > +++ b/common/Kconfig > > @@ -913,6 +913,10 @@ config BAREBOXCRC32_TARGET > > config POLLER > > bool "generic polling infrastructure" > > > > +config SLICE > > + depends on POLLER > > + default y > > + > > config STATE > > bool "generic state infrastructure" > > select CRC32 > > diff --git a/common/Makefile b/common/Makefile > > index 84463b4d48..16f14db41c 100644 > > --- a/common/Makefile > > +++ b/common/Makefile > > @@ -11,6 +11,7 @@ obj-y += bootsource.o > > obj-$(CONFIG_ELF) += elf.o > > obj-y += restart.o > > obj-y += poweroff.o > > +obj-y += slice.o > > obj-$(CONFIG_MACHINE_ID) += machine_id.o > > obj-$(CONFIG_AUTO_COMPLETE) += complete.o > > obj-y += version.o > > the Kconfig logic doesn't make sense to me. slice.o gets built regardless of > CONFIG_SLICE and it will still compile and link when CONFIG_POLLER is disabled. > On the other hand poller.o will fail to link when slice.o is omitted. > > I suggest we drop CONFIG_SLICE. I probably just added slice.o using obj-y initially to get started and then didn't look at it again.. Yes, dropping it seems right. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
