Re: [PATCH] mtd: mtdraw: Fix cdev size calculation for large NANDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 04, 2020 at 03:21:48PM +0200, Yunus Bas wrote:
> From: Stefan Riedmueller <s.riedmueller@xxxxxxxxx>
> 
> Raw size for large NAND devices (> 4 GB) can exceed 32 bits, so we need
> 64 bit types as factors. Both factors are of 32 bit types, as such is
> the return value. At least one factor needs to be 64 bit type when
> calculating the size.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@xxxxxxxxx>
> Signed-off-by: Christian Hemp <c.hemp@xxxxxxxxx>
> Signed-off-by: Yunus Bas <y.bas@xxxxxxxxx>
> ---
>  drivers/mtd/mtdraw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mtd/mtdraw.c b/drivers/mtd/mtdraw.c
> index f63da7b..b716192 100644
> --- a/drivers/mtd/mtdraw.c
> +++ b/drivers/mtd/mtdraw.c
> @@ -306,7 +306,7 @@ static int add_mtdraw_device(struct mtd_info *mtd, const char *devname, void **p
>  	mtdraw->mtd = mtd;
>  
>  	mtdraw->cdev.ops = (struct cdev_operations *)&mtd_raw_fops;
> -	mtdraw->cdev.size = mtd_div_by_wb(mtd->size, mtd) * mtdraw->rps;
> +	mtdraw->cdev.size = (loff_t)mtd_div_by_wb(mtd->size, mtd) * mtdraw->rps;
>  	mtdraw->cdev.name = basprintf("%s.raw", mtd->cdev.name);
>  	mtdraw->cdev.priv = mtdraw;
>  	mtdraw->cdev.dev = &mtd->class_dev;
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux