On Wed, Apr 29, 2020 at 09:06:53AM +0200, Ahmad Fatoum wrote: > On error, a goto may jump over the initialization of vmem and free the > uninitialized value during clean up. Fix this. > > Found by compiling the code with clang. > > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > --- > drivers/video/ssd1307fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/drivers/video/ssd1307fb.c b/drivers/video/ssd1307fb.c > index 835814bf5306..45f479b0efdc 100644 > --- a/drivers/video/ssd1307fb.c > +++ b/drivers/video/ssd1307fb.c > @@ -395,7 +395,7 @@ static int ssd1307fb_probe(struct device_d *dev) > u32 vmem_size; > struct ssd1307fb_par *par; > struct ssd1307fb_array *array; > - u8 *vmem; > + u8 *vmem = NULL; > int ret; > int i, j; > > -- > 2.26.2 > > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
