Hello Roland, On Thu, Apr 23, 2020 at 10:13:24AM +0200, Roland Hieber wrote: > It's already applied now, but for the future, such large patches are > really easier to review when they do only one thing at a time (replacing > the boilerplate with license identifiers, changing copyright tags, > changing old to new identifiers, adding new identifiers etc.). > > That that, I couldn't find any errors, but that doesn't mean there > aren't any. :) That's one side of the coin. The other is that several patches touching all the same area result in more work to create the patches and make patch and commit handling more complicated. While I agree in general that one-patch-does-one-thing is a good concept I think for rearrangements like this fixing all files in a directory in one go is fine. Otherwise the result are patches that just add empty lines before comments which IMHO doens't justify a patch. Doing this en passant is fine however. Sascha, what's your position here? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
