On Mon, Apr 20, 2020 at 08:25:37AM +0200, Ahmad Fatoum wrote: > On 4/20/20 8:22 AM, Sascha Hauer wrote: > > On Wed, Apr 15, 2020 at 11:29:13AM +0200, Ahmad Fatoum wrote: > >> The sdhci_readN accessors don't lend themselves for clean use with > >> readx_poll_timeout because they accept two arguments. Add > >> a sdhci-specific helper, so the sdhci drivers can cut down on the > >> timeout loop boilerplate. > > > Is this really an improvement? How many variants of these helpers will we get? > > It's used 6 times within this series. Other SDHCI drivers can make use of it too. > Would you prefer extending <linux/iopoll.h> with a two arg accessor variant > instead? I just found that Linux very recently got read_poll_timeout. With this this can be solved nicely. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
