Hello Roland, On Mon, Apr 20, 2020 at 10:46:57AM +0200, Roland Hieber wrote: > On Fri, Apr 17, 2020 at 10:33:08PM +0200, Uwe Kleine-König wrote: > > While at it also drop references to the non-existing CREDITS file. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > Hello, > > > > there is one file (2048.c) that specifies the MIT license. I wonder if > > we should use "GPL-2.0 OR MIT" there as effectively as distributed with > > barebox it is licensed under the GPL 2, isn't it? > > I would stay as close to the source as possible. MIT and GPL-2.0 are > compatible, so there is no problem on the project level, and I see no > reason to handle this on the level of individual files. fine for me. > > diff --git a/commands/2048.c b/commands/2048.c > > index 865803a5a616..f5f86940e80e 100644 > > --- a/commands/2048.c > > +++ b/commands/2048.c > > @@ -1,6 +1,5 @@ > > +// SPDX-License-Identifier: MIT > > /* > > - * The MIT License (MIT) > > - * > > * Copyright (c) 2014 Maurits van der Schee > > * > > * Permission is hereby granted, free of charge, to any person obtaining a copy > > These boilerplate lines could be removed too. I wasn't sure this is the right thing as "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." Probably this is not relevant when we include the license as Ahmad pointed out. > > +// SPDX-License-Identifier: GPL-2.0+ > > GPL-2.0+ is the old-style identifier, which is deprecated by SPDX (see > https://spdx.org/licenses/ at the bottom). I think we should also use > new-style GPL-2.0-or-later or GPL-2.0-only here. > > The rest looks okay. Thanks for picking this up! Thanks for looking through the patch and giving feedback. Will send a revised patch later (or tomorrow). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
