On Wed, Apr 15, 2020 at 07:54:09PM +0900, Masahiro Yamada wrote: > On Wed, Apr 15, 2020 at 6:40 PM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > > > On Wed, Apr 15, 2020 at 04:59:17PM +0900, Masahiro Yamada wrote: > > > Fix the relative include path in <linux/libfdt.h> > > > > > > Including <linux/kernel.h> is too much. <linux/limits.h> is enough > > > for INT_MAX. > > > > > > Define INT32_MAX and UINT32_MAX in the same way as Linux does. > > > > > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > > > --- > > > > > > include/linux/libfdt.h | 2 +- > > > include/linux/libfdt_env.h | 7 ++++--- > > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > Applied, thanks. > > > > > > > > diff --git a/include/linux/libfdt.h b/include/linux/libfdt.h > > > index ef2467213..90ed4ebfa 100644 > > > --- a/include/linux/libfdt.h > > > +++ b/include/linux/libfdt.h > > > @@ -3,6 +3,6 @@ > > > #define _INCLUDE_LIBFDT_H_ > > > > > > #include <linux/libfdt_env.h> > > > -#include "../scripts/dtc/libfdt/libfdt.h" > > > +#include "../../scripts/dtc/libfdt/libfdt.h" > > > > I wonder why this obviously wrong path worked before. > > > This is because the $(srctree)/include/ > is added to the header search paths. > > > The top Makefile defines it as follows: > > LINUXINCLUDE := -Iinclude -I$(srctree)/dts/include \ > $(if $(KBUILD_SRC), -I$(srctree)/include) \ > -I$(srctree)/arch/$(ARCH)/include \ > -I$(objtree)/arch/$(ARCH)/include \ > -include $(srctree)/include/linux/kconfig.h > > > > The previous "../scripts/dtc/libfdt/libfdt.h" > works because it is relative to $(srctree)/include/ Ah, "file" falls back to <file> when file is not found in the relative path. I tend to forget that. Regards, Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
