Hi Michael,
On Thu, Apr 02, 2020 at 08:23:56AM +0000, Michael Graichen wrote:
> This adds support to programm the PL part of the Zynq SoC,
> but only the non-secure way and no partial reconfiguration.
> It adds the 'zynq_fpga_manager' so we can use
>
> firmwareload -l
> firmwareload -t zynq-fpga-manager /mnt/mmc0.0/design_1_wrapper.bit
>
> to programm the PL.
...
>
> + start = get_time_ns();
> + while (1) {
> + reg = readl(mgr->regs + STATUS_OFFSET);
> +
> + if(!(reg & STATUS_PCFG_INIT_MASK))
> + break;
> +
> + if (is_timeout(start, 100 * MSECOND))
> + return -ETIMEDOUT;
> + }
You can use readl_poll_timeout() as a shortcut to such
register-poll-timeout loops.
The code looks good to me, but the patches need some coding style polish
before I can apply them. There are a lot of trailing whitespaces.
Indentation should be done with tabs, tab width is 8 chars.
Also the patches lack a "Signed-off-by:" line
Regards,
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
