Hi Michael, On Fri, Mar 27, 2020 at 09:57:11AM +0000, Michael Graichen wrote: > Hey, > > i've attached some fixes for the zedboard build that worked, at least, > for me. > The MIO config in lowlevel.c seem to be very "hardware specific" but > one can compare this to what Xilinx Vivado says. > > When including the drivers for Networking, QSPI and SD one will run > out of OCRAM very quickly that's why i commended out so much in the > defconfig. > > The changes to drivers/mci/Kconfig and drivers/mci/arasan-sdhci.c seem > to be bug fixes. > > Best regards and have a nice weekend > > Michael > > diff --git a/drivers/mci/Kconfig b/drivers/mci/Kconfig > index 80b3a2600..9f56bed3a 100644 > --- a/drivers/mci/Kconfig > +++ b/drivers/mci/Kconfig > @@ -141,6 +141,7 @@ config MCI_TEGRA > > config MCI_ARASAN > bool "Arasan SDHCI Controller" > + select MCI_SDHCI > help > Enable this to support SD and MMC card read/write on systems with > the Arasan SD3.0 / SDIO3.0 / eMMC4.51 host controller. Can you make this a separate patch please? > diff --git a/drivers/mci/arasan-sdhci.c b/drivers/mci/arasan-sdhci.c > index b43a4f8dd..0dd9382ae 100644 > --- a/drivers/mci/arasan-sdhci.c > +++ b/drivers/mci/arasan-sdhci.c > @@ -278,7 +278,7 @@ static int arasan_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd, > > mask = SDHCI_INT_CMD_COMPLETE; > if (data) > - mask |= SDHCI_INT_XFER_COMPLETE; > + mask |= SDHCI_INT_DATA_AVAIL; And this one as well. Please also add to the commit log what is going wrong here. I can't say much to the changes in the lowlevel code, but they should be done as separate patches and with better commit messages. Regards Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
