Hi Jules, On Thu, Mar 26, 2020 at 07:33:04PM +0100, Jules Maselbas wrote: > The gadget driver set the bInterfaceProtocol value to 1 in the DFU > interface descriptor. However this value is used to indicate that the > gadget is in run-time mode and not ready for DFU. When ready for DFU > operation the bInterfaceProtocol value must be set to 2 (DFU mode). > > From the DFU 1.1 specification, the value of bInterfaceProtocol select: > - 1: Runtime protocol (see Table 4.1) > - 2: DFU mode protocol (see Table 4.4) > > This patch change the bInterfaceProtocol value from 1 to 2. As this > DFU gadget driver is always ready for DFU operation (DFU mode) and > doesn't require a USB reset. > > Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxxx> DFU stopped working for me quite a while ago and I tracked it down to this dfu-util commit: | commit 377f6f136d3369529f44578acaeee82d7c7d7af9 | Author: Paul Fertser <fercerpav@xxxxxxxxx> | Date: Sun Aug 10 14:26:05 2014 +0400 | | dfu_util: Ignore alt_index/alt_name specification in runtime mode | | When the device is in runtime mode it needs to be reset first into DFU | mode for the list of alternate settings to appear, so unless it is | already in the right mode, matching on alt setting number or name | should be skipped. | | Fixes regression on OpenMoko Freerunner. | | Signed-off-by: Paul Fertser <fercerpav@xxxxxxxxx> Are you using a recent dfu-util version? Is your patch the fix for this commit? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
