Hi Giorgio,
thanks for the report. I've sent a patch to fix this issue.
Regards,
Lucas
Am Freitag, den 20.03.2020, 13:47 +0100 schrieb Giorgio Dal Molin:
> Hi,
>
> I'm getting a compile error while building barebox for an imx7d after
> configuring in CONFIG_RESET_IMX7:
>
> ...
> CHK include/generated/compile.h
> CC drivers/reset/reset-imx7.o
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: error: 'IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N'?
> 181 | [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) },
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: error: array index in initializer not of integer type
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: note: (near initialization for 'imx8mq_src_signals')
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: error: 'IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N'?
> 182 | [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) },
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: error: array index in initializer not of integer type
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: note: (near initialization for 'imx8mq_src_signals')
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: error: 'IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N'?
> 183 | [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) },
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: error: array index in initializer not of integer type
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: note: (near initialization for 'imx8mq_src_signals')
> make[3]: *** [/home/giorgio/projects/wpt_barebox/scripts/Makefile.build:215: drivers/reset/reset-imx7.o] Error 1
> make[2]: *** [/home/giorgio/projects/wpt_barebox/scripts/Makefile.build:367: drivers/reset] Error 2
> make[1]: *** [/home/giorgio/projects/wpt_barebox/Makefile:804: drivers] Error 2
> make: *** [Makefile:118: sub-make] Error 2
>
>
> After a bit of search I've found the following two nearly identical headers:
>
> -1- include/dt-bindings/reset/imx8mq-reset.h
> -2- dts/include/dt-bindings/reset/imx8mq-reset.h
>
> maybe there is a typo (DSI <=> DIS):
>
> #define IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N 23
> #define IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N 24
> #define IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N 25
>
> #define IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N 23
> #define IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N 24
> #define IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N 25
>
> giorgio
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
