Re: [PATCH 0/2] Allow parsing more than one memory node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sam,

----- On 17 Mar, 2020, at 08:35, Sam Ravnborg sam@xxxxxxxxxxxx wrote:

> Hi Clement.
> 
> On Mon, Mar 16, 2020 at 12:00:06PM +0100, Clement Leger wrote:
>> Currently, barebox can only parse one memory node. This means that
>> all other memory nodes (with device_type == "memory") will be ignored
>> while parsing memory.
>> This patchset add a function of_probe_memory which will call
>> of_add_memory for each found memory node. Additionally, of_add_memory
>> has been modified to allow being called multiple times and correctly
>> add all memory banks.
>> 
>> Clement Leger (2):
>>   of: base: parse all available memory nodes
>>   of: base: allow of_add_memory to be called multiple times
> 
> With this order of the patches, after applying patch 1 the
> code will then use the last and not the first memory node.
> And only after the second patch it will work.
> 
> I think to improve bisectability the order of the two patches should be
> reversed.

Oh yes indeed ! I will send a V2 after others have commented it.

> 
> 	Sam

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux