On Fri, Mar 13, 2020 at 10:03:26AM +0100, Sascha Hauer wrote: > On Thu, Mar 12, 2020 at 11:46:07PM +0300, Peter Mamonov wrote: > > Signed-off-by: Peter Mamonov <pmamonov@xxxxxxxxx> > > --- > > drivers/serial/serial_ns16550.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c > > index 3edeb0dcb..6b5e92c13 100644 > > --- a/drivers/serial/serial_ns16550.c > > +++ b/drivers/serial/serial_ns16550.c > > @@ -39,6 +39,7 @@ > > #include <malloc.h> > > #include <io.h> > > #include <linux/clk.h> > > +#include <pinctrl.h> > > > > #include "serial_ns16550.h" > > #include <platform_data/serial-ns16550.h> > > @@ -347,6 +348,8 @@ static void ns16550_probe_dt(struct device_d *dev, struct ns16550_priv *priv) > > dev_err(dev, "unsupported reg-io-width (%d)\n", > > width); > > } > > + > > + of_pinctrl_select_state_default(np); > > Why? This should have been done by the core already at this point. I struggled with this problem http://lists.infradead.org/pipermail/barebox/2020-March/041206.html yesterday, and my first guess was that pinctrl doesn't apply. So I made this patch and didn't revert it after finding the real solution. I will do so later. Thanks for explanation! Peter > > Sascha > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
