Re: [PATCH] usb: Add extra delay for device scan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 09, 2020 at 03:20:26PM +0100, Christian Eggers wrote:
> Since b1d9837182, detection of various USB flash drives stopped working.
> While the changes itself look correct, probably the HUB requires some
> "recovery time" between the GET_STATUS commands in order to be able to
> detect devices.
> 
> Our configuration: i.MX6ULL (USB-OTG) with only one port on the root
> HUB. This port is connected to a Microchip USB4916 hub (permanently
> attached). The USB4916 is configured with it's power on defaults which
> means that bPwrOn2PwrGood is set to the maximum (0xFF = 510 ms).
> 
> Fixes: b1d9837182 ("b1d9837182d2b20232234adb36ada2129c3a8152")

This should probably be:?

  Fixes: b1d9837182 ("usb: Change power-on / scanning timeout handling")


 - Roland

> Signed-off-by: Christian Eggers <ceggers@xxxxxxx>
> ---
>  drivers/usb/core/hub.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 8874775f17..466bbe527b 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -406,6 +406,9 @@ static int usb_device_list_scan(void)
>  			if (ret)
>  				goto out;
>  		}
> +
> +		/* Avoid hammering the HUB with port scans */
> +		mdelay(25);
>  	}
>  
>  out:
> -- 
> Christian Eggers
> Embedded software developer
> 
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
> Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
> Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@xxxxxxxxxxxxxx     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux