Hello Yegor, On 2/28/20 11:27 AM, Yegor Yefremov wrote: > Hi Ahmad, > > On Wed, Feb 26, 2020 at 11:48 AM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote: >> >> The NULL assignment is a left over from when it was a global variable. >> am_usbphy is local now and is just going out of scope, so need to NULL >> it. >> >> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> >> --- >> drivers/usb/musb/phy-am335x.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/usb/musb/phy-am335x.c b/drivers/usb/musb/phy-am335x.c >> index 7dda8caf2a3c..f2e870d7ee61 100644 >> --- a/drivers/usb/musb/phy-am335x.c >> +++ b/drivers/usb/musb/phy-am335x.c >> @@ -60,7 +60,6 @@ err_release: >> release_region(iores); >> err_free: >> free(am_usbphy); >> - am_usbphy = NULL; >> >> return ret; >> }; > > Do you want me to test this fixup as well or are you going to post v2? You don't need to. It's a line that the compiler optimizes out anyway. Cheers Ahmad > > Yegor> -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
