On Thu, Feb 20, 2020 at 07:50:05AM +0100, Rouven Czerwinski wrote:
> An overlay might not contain a symbol node, in case it only adds new
> nodes to the device tree. Reword the error message and switch it from
> warning to info.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@xxxxxxxxxxxxxx>
> ---
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index de79e05cbc..9c1d5b5bcb 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -173,7 +173,7 @@ int of_overlay_apply_tree(struct device_node *root,
> /* Copy symbols from resolved overlay to base device tree */
> err = of_overlay_apply_symbols(root, resolved);
> if (err)
> - pr_warn("failed to copy symbols from overlay");
> + pr_info("could not copy symbols from overlay\n");
This message would still raise my eyebrows. Maybe move this message into
of_overlay_apply_symbols() and say something like "Overlay/root doesn't have
a __symbols__ node"?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
