On Mon, Feb 10, 2020 at 07:08:30PM +0100, Ahmad Fatoum wrote: > reset_control_get returns a NULL pointer when no resets were specified > via device tree properties. If there's a malformed "resets"-property, we > get an error pointer. This error should be propagated, only the NULL > returns are the ones we can safely ignore. > > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > --- > drivers/mci/stm32_sdmmc2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/drivers/mci/stm32_sdmmc2.c b/drivers/mci/stm32_sdmmc2.c > index 44f7e6239949..695e61d1ccd7 100644 > --- a/drivers/mci/stm32_sdmmc2.c > +++ b/drivers/mci/stm32_sdmmc2.c > @@ -622,7 +622,7 @@ static int stm32_sdmmc2_probe(struct amba_device *adev, > > priv->reset_ctl = reset_control_get(dev, NULL); > if (IS_ERR(priv->reset_ctl)) > - priv->reset_ctl = NULL; > + return PTR_ERR(priv->reset_ctl); > > mci->f_min = 400000; > /* f_max is taken from kernel v5.3 variant_stm32_sdmmc */ > -- > 2.25.0 > > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
