Re: [PATCH 0/3] commands/test: some improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 28, 2020 at 02:07:58PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> my main intention was to implement -b and -c, the other two patches just
> fix some stuff I noticed while doing so.
> 
> One thing I noticed is that the check for
> 
> 	strlen(ap[1])
> 
> in the handling of -e and others is wrong.
> 
> This makes
> 
> 	test -e ''
> 
> return success, but
> 
> 	test -z something -o -e ''
> 
> fails. I don't know for sure how to fix this as the empty string might
> mean "." sometimes?
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (3):
>   commands/test: Bail out on incomplete command line options
>   commands/test: Improve option parsing to handle "]" less special
>   commands/test: Implement -b and -c to test for character and block
>     devices
> 
>  commands/test.c | 32 +++++++++++++++++++++++++++-----
>  1 file changed, 27 insertions(+), 5 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux