Re: [PATCH v1] MIPS: remove .bss to __rel_start overlay

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 28 Jan 2020 14:53:07 +0100
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> Note:
> memtest on ar9331 works only with this patch:
> 
> diff --git a/arch/mips/lib/cpu-probe.c b/arch/mips/lib/cpu-probe.c
> index cbde43a595..0d2dcf8b03 100644
> --- a/arch/mips/lib/cpu-probe.c
> +++ b/arch/mips/lib/cpu-probe.c
> @@ -177,6 +177,9 @@ static int mips_request_stack(void)
>          if (!request_sdram_region("stack", mips_stack_top - STACK_SIZE, STACK_SIZE))
>                  pr_err("Error: Cannot request SDRAM region for stack\n");
> 
> +       if (!request_sdram_region("vector", 0x80000000, 0x8000))
> +               pr_err("Error: Cannot request SDRAM region for vector\n");
> +
>          return 0;
>   }
>   coredevice_initcall(mips_request_stack);


Can we put this request_sdram_region() into main_entry.c to keep it close to trap_init?
Thereby we have a change to reuse ebase value instead of the 0x80000000 magic constant.
Also 0x8000 size is too large. See MIPS Run, 2nd Edition by Dominic Sweetman states 
general exception entry point is BASE+0x180 (used by barebox), and Interrupt Special
starts at BASE+0x200 (not used by barebox), so 0x200 is just enough.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux