Re: [PATCH] bootchooser: Change name of kernel parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Christian,

On 1/27/20 8:46 AM, Christian Eggers wrote:
> When passing the target name as "bootchooser.active", Linux will not
> pass the parameter as environment variable to the init process. The only
> way to get the bootchooser result (e.g. in an initramfs), is to parse it
> out of /proc/cmdline (requires mounting of /proc, sed, ...).
> 
> After renaming, the bootchooser result will be passed as environment
> variable which can easily accessed from /init (e.g. for selecting the
> associated root fs).

Existing userspace like RAUC[1] rely on this naming, so the default may
not be changed.

[1]: https://github.com/rauc/rauc/blob/f52978d9736f18794f7e277ca440e2e4e78c9703/src/context.c#L47

Cheers
Ahmad

> 
> Signed-off-by: Christian Eggers <ceggers@xxxxxxx>
> ---
>  common/bootchooser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/bootchooser.c b/common/bootchooser.c
> index c08db03eb..f0e3294dc 100644
> --- a/common/bootchooser.c
> +++ b/common/bootchooser.c
> @@ -817,7 +817,7 @@ static int bootchooser_boot_one(struct bootchooser *bc, int *tryagain)
>  		goto out;
>  	}
>  
> -	system = basprintf("bootchooser.active=%s", target->name);
> +	system = basprintf("bootchooser_active=%s", target->name);
>  	globalvar_add_simple("linux.bootargs.bootchooser", system);
>  	free(system);
>  
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux