When disabling CONFIG_SHELL_HUSH, also CONFIG_PARAMETER may be disabled. In this case, the definition "enum param_tristate" is not reachable from watchdog.h. I also considered moving almost everything in watchdog.h inside the CONFIG_WATCHDOG guard. But this doesn't work for me because drivers/watchdog/imxwd.c can also be built without CONFIG_WATCHDOG. Signed-off-by: Christian Eggers <ceggers@xxxxxxx> --- @Sascha: I've asked my IT department to stop modifiying my patch emails. I hope the mails are ok now. include/param.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/param.h b/include/param.h index d75f50ea3..f1166eb28 100644 --- a/include/param.h +++ b/include/param.h @@ -37,6 +37,8 @@ struct param_d { enum param_type type; }; +enum param_tristate { PARAM_TRISTATE_UNKNOWN, PARAM_TRISTATE_TRUE, PARAM_TRISTATE_FALSE }; + #ifdef CONFIG_PARAMETER const char *get_param_type(struct param_d *param); const char *dev_get_param(struct device_d *dev, const char *name); @@ -63,8 +65,6 @@ struct param_d *dev_add_param_enum(struct device_d *dev, const char *name, int (*get)(struct param_d *p, void *priv), int *value, const char * const *names, int max, void *priv); -enum param_tristate { PARAM_TRISTATE_UNKNOWN, PARAM_TRISTATE_TRUE, PARAM_TRISTATE_FALSE }; - struct param_d *dev_add_param_tristate(struct device_d *dev, const char *name, int (*set)(struct param_d *p, void *priv), int (*get)(struct param_d *p, void *priv), -- 2.16.4 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox