Re: [PATCH] net: designware: eqos: don't funnel all MDIO writes to register 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 17, 2020 at 07:17:16PM +0100, Ahmad Fatoum wrote:
> eqos_mdio_write ended up using the addr parameter instead of the
> computed miiaddr variable, which would've factored in the reg parameter.
> 
> This had the effect that all writes went to PHY register 0, which was
> fine as long as there were only register 0 writes. As soon there are more
> writes, e.g. because a PHY driver was enabled, register 0 became
> clobbered and erratic behavior ensued.
> Fix the typo and while at it rename the val parameter to a more
> descriptive name.
> 
> Fixes: a4f709bbb ("net: add Designware Ethernet QoS for STM32MP")
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> Could this be applied to master? Thanks.

Did that.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux