Hi Sascha and Marcin, yes i will be change the patch. Maik . Am 06.01.2020 um 10:35 schrieb Sascha Hauer: > On Sun, Dec 22, 2019 at 11:13:48PM +0100, Marcin Niestrój wrote: >> Hi Sasha, Maik, >> >> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes: >> >>> On Wed, Dec 18, 2019 at 01:57:17PM +0100, Maik Otto wrote: >>>> the whole barebox with mbr and partition table were be signed by default. >>>> change the signing to the executed image without signing the mbr, >>>> partition table and header_gap by imx8mq >>>> additional delete option full, from-dcdofs and skip-mbr >>>> >>>> Signed-off-by: Maik Otto <m.otto@xxxxxxxxx> >>>> --- >>>> Changes in v2: >>>> - change subject from habv4: add the possibility to changing the signing >>>> area from Kconfig to >>>> - delete KConfig entries >>>> - delete changes habv4-imx6-gencsf.h >>>> - delete full, from-dcdofs and skip-mbr options >>>> --- >>>> scripts/imx/imx.c | 33 +++++++++------------------------ >>>> 1 file changed, 9 insertions(+), 24 deletions(-) >>> Applied, thanks. >>> >>> @Marcin, as you introduced the "from-dcdofs" and "full" options, are you >>> happy with this patch? It removes the options, but should default to >>> what you originally wanted to archieve, right? >> I think that when adding separate skip-mbr and from-dcdofs I wanted to >> protect (with skip-mbr) first bytes of generated image, which contain >> barebox header (with its version?) from what I remember. I never used >> that information from there, so I am quite okay with dropping skip-mbr >> support in favor of only from-dcdofs. > The version is not contained in the header. > >> However I wonder why offset_load_address is hardcoded to >> 0x400. Shouldn't we leave from-dcdofs as is and simply dropping all >> other options (full and skip-mbr)? > Yes, this sounds better. Maik, can you change the patch accordingly? > > Sascha > _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
