If led_set fails, the error code is the return value, not errno. Fix this. While at replace the magic value in the command return code. Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- commands/led.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/commands/led.c b/commands/led.c index a53f0df6a200..b608fcfa2cdb 100644 --- a/commands/led.c +++ b/commands/led.c @@ -101,8 +101,8 @@ static int do_led(int argc, char *argv[]) ret = led_set(led, value); if (ret < 0) { - perror("led"); - return 1; + printf("led: %s\n", strerror(-ret)); + return COMMAND_ERROR; } return 0; -- 2.24.0 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox