Re: [PATCH v2 2/4] image-metadata: add flags field to imd_header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 09, 2019 at 11:42:36AM +0100, Steffen Trumtrar wrote:
> To allow marking an imd tag with properties, add a flags field to the imd_header.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> ---
>  include/image-metadata.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/image-metadata.h b/include/image-metadata.h
> index 5904d95acd37..ca73e6cf6ec6 100644
> --- a/include/image-metadata.h
> +++ b/include/image-metadata.h
> @@ -28,6 +28,8 @@
>  #define IMD_TYPE_END		0x640c7fff
>  #define IMD_TYPE_INVALID	0xffffffff
>  
> +#define IMD_FLAG_TAG_VALID	(1 << 0)
> +
>  /*
>   * The IMD header. All data is stored in little endian format in the image.
>   * The next header starts at the next 4 byte boundary after the data.
> @@ -35,6 +37,7 @@
>  struct imd_header {
>  	uint32_t type;		/* One of IMD_TYPE_* above */
>  	uint32_t datalength;	/* Length of the data (exluding the header) */
> +	uint32_t flags;
>  };

Erm, no. struct imd_header shouldn't be changed, this breaks the imd
tool. What I meant is that the valid flag should be added to the crc
tag.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux