Re: [PATCH 2/7] ARM: dts: imx6: pcaaxl3: Update license and model description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 09, 2019 at 10:01:43AM +0100, Stefan Riedmueller wrote:
> Make use of SPDX license identifiers and update copyright notices and
> model descriptions of the phyCARD-i.MX 6 SOM.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@xxxxxxxxx>
> ---
>  arch/arm/dts/imx6q-phytec-pbaa03.dts   | 13 ++++---------
>  arch/arm/dts/imx6q-phytec-pcaaxl3.dtsi | 14 +++-----------
>  2 files changed, 7 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm/dts/imx6q-phytec-pbaa03.dts b/arch/arm/dts/imx6q-phytec-pbaa03.dts
> index 4724a02ad7d8..b11b8b3f93fe 100644
> --- a/arch/arm/dts/imx6q-phytec-pbaa03.dts
> +++ b/arch/arm/dts/imx6q-phytec-pbaa03.dts
> @@ -1,19 +1,14 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later)
>  /*
> - * Copyright 2014 Christian Hemp, Phytec Messtechnik GmbH
> - *
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
> - *
> - * http://www.opensource.org/licenses/gpl-license.html
> - * http://www.gnu.org/copyleft/gpl.html
> + * Copyright (C) 2014 PHYTEC Messtechnik GmbH
> + * Author: Christian Hemp <c.hemp@xxxxxxxxx>
>   */
>  
>  /dts-v1/;
>  #include "imx6q-phytec-pcaaxl3.dtsi"
>  
>  / {
> -	model = "Phytec phyCARD-i.MX6 Quad Carrier-Board";
> +	model = "PHYTEC phyCARD-i.MX6 Quad";
>  	compatible = "phytec,imx6q-pbaa03", "phytec,imx6q-pcaaxl3", "fsl,imx6q";
>  
>  	chosen {
> diff --git a/arch/arm/dts/imx6q-phytec-pcaaxl3.dtsi b/arch/arm/dts/imx6q-phytec-pcaaxl3.dtsi
> index db986f87ef26..5e0495996d52 100644
> --- a/arch/arm/dts/imx6q-phytec-pcaaxl3.dtsi
> +++ b/arch/arm/dts/imx6q-phytec-pcaaxl3.dtsi
> @@ -1,21 +1,13 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later)
>  /*
> - * Copyright 2014444 Christian Hemp, Phytec Messtechnik GmbH

Oh, code from the future :)

> - *
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
> - *
> - * http://www.opensource.org/licenses/gpl-license.html
> - * http://www.gnu.org/copyleft/gpl.html
> + * Copyright (C) 2014 PHYTEC Messtechnik GmbH
> + * Author: Christian Hemp <c.hemp@xxxxxxxxx>
>   */

For the license part:
Reviewed-by: Roland Hieber <rhi@xxxxxxxxxxxxxx>

>  
>  #include <arm/imx6q.dtsi>
>  #include "imx6q.dtsi"
>  
>  / {
> -	model = "Phytec phyCARD-i.MX6 Quad";
> -	compatible = "phytec,imx6q-pcaaxl3", "fsl,imx6q";
> -

... but this looks like an accidental change to me, or did you really
want to have a device tree without a compatible?

 - Roland

>  	chosen {
>  		environment-nand {
>  			compatible = "barebox,environment";
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@xxxxxxxxxxxxxx     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux