Re: [PATCH] ARM: dts: imx6qdl: phycore: Remove emmc vmmc-supply

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefan,

On Tue, Dec 03, 2019 at 02:48:41PM +0100, Stefan Riedmueller wrote:
> There is no driver for the eMMC's vmmc-supply regulator in the barebox.
> Use a dummy regulator instead by simply deleting the vmmc-supply
> property.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@xxxxxxxxx>
> ---
>  arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> index 69f252b42382..974e271f453d 100644
> --- a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -112,6 +112,7 @@
>  };
>  
>  &usdhc4 {
> +	/delete-property/ vmmc-supply;

I don't like this approach very much. It's fine for barebox, but leads
to problems once you start Linux with the barebox device tree. I'd
rather go with the unmodified device trees (apart from the things
barebox changes to the device trees in order to start Linux).

One idea that comes to my mind is: Would it be possible to provide a
call like

int regulator_provide_dummy(struct device_node *np);

Boards could call this to let barebox provide a dummy regulator for the
given node (the "dlg,da9062" node in your case) and its child nodes.
In of_regulator_get() we then see if the desired regulator is a child
node of a node registered as dummy provider, then register a dummy
regulator and return it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux