On Mon, Dec 02, 2019 at 11:24:48AM +0100, Juergen Borleis wrote:
> This change removes the stupid error message at the end of the generated
I think there was some reason behind that code, so it is probably not
stupid, and you've run into an edge case that never happened before (at
least I've never seen this on any of my boards when using HABv4).
The code goes back until the first incarnaction of HABv4 in commit
29abc10d44c2 - Marc, do you still know more details why it was done this
way?
- Roland
> list of HAB events. It seems it was added for debugging/development
> purposes, because it always reports an error like
>
> "HABv4: ERROR: Recompile with larger event data buffer (at least 20 bytes)"
>
> which is completely nonsense, since the we already provide a buffer with
> 256 bytes...
>
> Signed-off-by: Juergen Borleis <jbe@xxxxxxxxxxxxxx>
> ---
> drivers/hab/habv4.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c
> index e3c1de1a4d..f1f45648f5 100644
> --- a/drivers/hab/habv4.c
> +++ b/drivers/hab/habv4.c
> @@ -555,12 +555,6 @@ static int habv4_get_status(const struct habv4_rvt *rvt)
> index++;
> }
>
> - /* Check reason for stopping */
> - len = sizeof(data);
> - index = 0;
> - if (rvt->report_event(HAB_STATUS_ANY, index, NULL, &len) == HAB_STATUS_SUCCESS)
> - pr_err("ERROR: Recompile with larger event data buffer (at least %d bytes)\n\n", len);
> -
> return -EPERM;
> }
>
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Roland Hieber, Pengutronix e.K. | r.hieber@xxxxxxxxxxxxxx |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
