On Fri, Nov 22, 2019 at 07:57:03PM +0800, Du Huanpeng wrote: > Hi. > > > Actually all of this lines haw incorrect coding style. It should be 80 > > char width style. > I see this, but it is more practical here. the editor will automatic warp lines. > > I can write a better description and send a v2 patch. Please do so. Please don't take 80 chars as a hard limit. While I think the lines we are talking about here are a bit long, forcing it to 80 chars doesn't really improve readability. i.e the following looks good, eventhough it's longer than 80 chars: cflags-$(CONFIG_CPU_LOONGSON1) += \ $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \ -Wa,-mips32r2 -Wa,--trap Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
