On Thu, Nov 14, 2019 at 02:23:44PM +0100, Ahmad Fatoum wrote: > Hello Sascha, > > On 11/14/19 2:00 PM, Sascha Hauer wrote: > > edev->halt is implemented, but not called by the core during shutdown. > > Oh, that's news to me. Apparently only eth_unregister calls ->halt and that > one is only used by drivers. Shouldn't calling eth_unregister be a part of > the barebox shutdown sequence? > I had the same thought as well and have put it on my mental todo list. It would be easy to put calling of edev->halt() somewhere in the shutdown path, but this would result in edev->halt() being called twice for drivers which already do this in their own remove function. I'm not sure every driver handles this fine so we probably have to make sure it is called only once. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
