On Wed, Nov 06, 2019 at 08:10:32AM +0100, Ahmad Fatoum wrote:
> In cases where firmware provides PSCI >0.1, it may be prudent to use it as
> backend for reset and poweroff. This driver accomplishes this.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> drivers/misc/Kconfig | 5 +++
> drivers/misc/Makefile | 1 +
> drivers/misc/psci-sysreset.c | 62 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 68 insertions(+)
> create mode 100644 drivers/misc/psci-sysreset.c
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 0f736f8bded3..0412fcf02aa3 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -35,4 +35,9 @@ config UBOOTVAR
> While it can be used standalone, it is best when coupled
> with corresponding filesystem driver.
>
> +config PSCI_SYSRESET
> + bool "PSCI system reset driver"
> + select ARM_PSCI_CLIENT
> + depends on CPU_32v7 || CPU_64v8
I would rather prefer to be ARM_PSCI_CLIENT a user visible option.
> +static int __init psci_sysreset_init(void)
> +{
> + int version;
> + int ret;
> +
> + version = psci_get_version();
> + if (version < 0)
> + return version;
This prints a warning for everyone who has this code enabled but doesn't
have psci support. Also you enforce that the psci client driver has to
be registered already.
I think this code should rather be merged into the psci client driver,
there's no need for an additional initcall.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
