Hi Robert, On 19-11-04 15:59, Robert Karszniewicz wrote: > On 11/4/19 3:54 PM, Marco Felsch wrote: > > Hi Sascha, > > > > On 19-11-04 10:42, Sascha Hauer wrote: > > > On Fri, Oct 25, 2019 at 05:56:08PM +0200, Robert Karszniewicz wrote: > > > > This should make writing and reading more reliable. > > > > > > > > Also: > > > > - change loop condition to make "retries" semantically correct > > > > - add a debug message in case of fatal failure > > > > --- > > > > We've had problems writing (and even reading) a 10 MiB file from barebox > > > > to multiple USB flash drives. > > > > The 10 MiB file copy failed with "write: I/O error" almost every time. > > > > Increasing the retry count made 100 MiB file copies succeed every time. > > > > > > > > > > Doing this doesn't hurt, so I applied this patch. I wonder though if > > > there's something else wrong which makes increasing the retry counts > > > necessary. > > > > > > Sascha > > > > there is a missing sob is that okay with you? Robert can you add a > > signed-off-by line? > > > > Oops, I'm sorry for that! How do we handle this? Should I just amend and > resubmit the patch? Resend as you already did is fine :) else you could reply with your sob-tag. Regards, Marco > > Regards, > > Marco > > > > _______________________________________________ > > barebox mailing list > > barebox@xxxxxxxxxxxxxxxxxxx > > http://lists.infradead.org/mailman/listinfo/barebox > > > > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
