Re: [PATCH] usb: storage: Increase retries for usb_stor_transport()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/4/19 10:42 AM, Sascha Hauer wrote:
On Fri, Oct 25, 2019 at 05:56:08PM +0200, Robert Karszniewicz wrote:
This should make writing and reading more reliable.

Also:
- change loop condition to make "retries" semantically correct
- add a debug message in case of fatal failure
---
We've had problems writing (and even reading) a 10 MiB file from barebox
to multiple USB flash drives.
The 10 MiB file copy failed with "write: I/O error" almost every time.
Increasing the retry count made 100 MiB file copies succeed every time.


Doing this doesn't hurt, so I applied this patch. I wonder though if
there's something else wrong which makes increasing the retry counts
necessary.

Sascha



Thanks, yes, so I thought, too; it doesn't hurt, so I sent it in.

From when I looked at the problem, it seemed to me that the whole USB flash drives thing is fickle. I glanced at the USB storage drivers of Linux and saw that they have a bunch of workarounds and per-device quirks. So Linux' drivers simply seem more mature and tolerant than those in barebox.

Robert

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux