Re: [PATCH] parameter: strip leading and trailing whitespaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 30, 2019 at 06:03:39PM +0100, Marco Felsch wrote:
> My initial bug was the following: I set the
> global.boot.default="boot1 boot2 " and executed the 'boot' command. If
> both targets are not bootable barebox starts to execute the boot scripts
> found under /env/boot. This is because of the command/boot.c
> implementation and the leading whitespace. Without the whitespace only
> the two desired boot targets are tried.
> 
> IMHO leading and trailing whitespaces are error-prone in many cases. If
> someone wants to concatenate strings he/she should add spaces on
> purpose. So I fixed the bug above globally by always stripping leading
> and trailing whitespaces.
> 
> Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> ---
>  lib/parameter.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux