On 10/15/19 9:59 AM, Sascha Hauer wrote: > On Tue, Oct 15, 2019 at 08:58:23AM +0200, Ahmad Fatoum wrote: >> Hello, >> >> On 10/14/19 2:51 PM, Sascha Hauer wrote: >>> On Mon, Oct 14, 2019 at 08:39:21AM +0200, Ahmad Fatoum wrote: >>>> Now with the SD/MMC controller supported, lets add a bbu handler, so we >>>> can use it to update the second stage boot loader partition. >>>> >>>> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> >>>> --- >>>> arch/arm/boards/stm32mp157c-dk2/board.c | 14 ++++++++++++++ >>>> arch/arm/mach-stm32mp/include/mach/bbu.h | 14 ++++++++++++++ >>>> 2 files changed, 28 insertions(+) >>>> create mode 100644 arch/arm/mach-stm32mp/include/mach/bbu.h >>>> >>>> diff --git a/arch/arm/boards/stm32mp157c-dk2/board.c b/arch/arm/boards/stm32mp157c-dk2/board.c >>>> index 9cb861af85d8..23eb6728b15a 100644 >>>> --- a/arch/arm/boards/stm32mp157c-dk2/board.c >>>> +++ b/arch/arm/boards/stm32mp157c-dk2/board.c >>>> @@ -4,6 +4,7 @@ >>>> #include <init.h> >>>> #include <asm/memory.h> >>>> #include <mach/stm32.h> >>>> +#include <mach/bbu.h> >>>> >>>> static int dk2_mem_init(void) >>>> { >>>> @@ -15,3 +16,16 @@ static int dk2_mem_init(void) >>>> return 0; >>>> } >>>> mem_initcall(dk2_mem_init); >>>> + >>>> +static int dk2_postcore_init(void) >>>> +{ >>>> + if (!of_machine_is_compatible("st,stm32mp157c-dk2")) >>>> + return 0; >>>> + >>>> + stm32mp_bbu_mmc_register_handler("sd", "/dev/disk0.ssbl", >>>> + BBU_HANDLER_FLAG_DEFAULT); >>> >>> You should create an alias in dt for the sd device node (might exist >>> already, don't know) and use mci_of_parse_node() in the SD driver. With >>> this you get consistent names. "disk0" will be different devices >>> depending on probe order. >> >> Ah, ok. I'll resend when Oleksij resends his. >> The first patch would be useful to have for other boards as well. >> Could you apply it seperately? > > I applied all other patches except this one. Environment on SD cards > doesn't obviously work as long as the driver is not there, but that > should be a reason to not apply this series, right? Great, thanks Ahmad > > Sascha > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox