Hey Andrey,
On 9/24/19 7:18 PM, Andrey Smirnov wrote:
> On Tue, Sep 24, 2019 at 6:29 AM Bastian Krause <bst@xxxxxxxxxxxxxx> wrote:
>>
>> Pass the OCOTP unique id as hashable information to machine id
>> generation.
>>
>> Signed-off-by: Bastian Krause <bst@xxxxxxxxxxxxxx>
>> ---
>> drivers/nvmem/ocotp.c | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c
>> index 3f9f162860..d5e9d72a52 100644
>> --- a/drivers/nvmem/ocotp.c
>> +++ b/drivers/nvmem/ocotp.c
>> @@ -29,6 +29,7 @@
>> #include <regmap.h>
>> #include <linux/clk.h>
>> #include <mach/ocotp.h>
>> +#include <machine_id.h>
>> #include <linux/nvmem-provider.h>
>>
>> /*
>> @@ -77,6 +78,9 @@
>> #define MAC_OFFSET_1 (0x24 * 4)
>> #define MAX_MAC_OFFSETS 2
>> #define MAC_BYTES 8
>> +#define UNIQUE_ID_NUM 2
>> +/* 0 <= n < UNIQUE_ID_NUM */
>> +#define UNIQUE_ID(n) (OCOTP_WORD(0x410 + 0x10 * (n)) | OCOTP_BIT(0) | OCOTP_WIDTH(32))
>
> There already OCOTP_UNIQUE_ID() in
> arch/arm/mach-imx/include/mach/ocotp-fusemap.h might make sense to
> re-use it.
Yes.
>
>>
>> enum imx_ocotp_format_mac_direction {
>> OCOTP_HW_TO_MAC,
>> @@ -548,6 +552,23 @@ static int imx_ocotp_read(struct device_d *dev, const int offset, void *val,
>> return regmap_bulk_read(priv->map, offset, val, bytes);
>> }
>>
>> +static int imx_ocotp_set_unique_machine_id(void)
>
> The return value of this function is not used anywhere in this patch.
> Maybe it would make sense to convert it to void and simplify the rest
> of the code?
You're right, will include it in v4.
Thanks!
Regards,
Bastian
--
Pengutronix e.K.
Industrial Linux Solutions
http://www.pengutronix.de/
Peiner Str. 6-8, 31137 Hildesheim, Germany
Amtsgericht Hildesheim, HRA 2686
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
