Re: [PATCH 2/2] reset_source: drop reset_source_set_instance()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 25, 2019 at 7:55 AM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> The semantic of reset_source_set_instance() required a separate call to
> reset_source_set() (or reset_source_set_priority()) and checked right
> usage only using the type. Make the set of functions a bit easier to use
> by dropping reset_source_set_instance() and instead introduce a function
> that can set all relevant parameters (source, priority and instance) in
> one go.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  arch/arm/mach-imx/imx.c       |  4 +---
>  common/reset_source.c         | 15 ++++-----------
>  drivers/watchdog/stm32_iwdg.c |  3 +--
>  include/reset_source.h        | 20 +++++++++++---------
>  4 files changed, 17 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx.c b/arch/arm/mach-imx/imx.c
> index 63914d306e6f..43b540b39771 100644
> --- a/arch/arm/mach-imx/imx.c
> +++ b/arch/arm/mach-imx/imx.c
> @@ -199,9 +199,7 @@ void imx_set_reset_reason(void __iomem *srsr,
>                 }
>         }
>
> -       reset_source_set_priority(type,
> -                                 RESET_SOURCE_DEFAULT_PRIORITY);
> -       reset_source_set_instance(type, instance);
> +       reset_source_set_prinst(type, RESET_SOURCE_DEFAULT_PRIORITY, instance);

Any change we can call this function
reset_source_set_priority_instance() or reset_source_set_all() instead
of "prinst"?

Thanks,
Andrey Smirnov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux