Re: [PATCH v2 3/3] console: fix out-of-bounds read in dputc(/dev/*, ...)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sascha,

On 8/23/19 9:07 AM, Sascha Hauer wrote:
> On Thu, Aug 22, 2019 at 09:06:09AM +0200, Ahmad Fatoum wrote:
>> Hello Sascha,
>>
>> On 7/31/19 12:21 PM, Ahmad Fatoum wrote:
>>> Trying to output a single character via
>>> 	echo -a /dev/serial0-1
>>> currently results in garbage output after the newline, because console.c's
>>> fops_write discards the buffer length and passes the buffer to
>>> (struct cdev)::puts which only handles NUL-terminated strings.
>>>
>>> Fix this by amending (struct cdev)::puts with a new nbytes parameter,
>>> which is correctly propagated.
>>
>> Can this one be merged? It doesn;t depend on the other two patches.
> 
> Ok. Can you rebase it? Without the others it doesn't seem to apply.

done. I dropped the RATP one, but squashed the other.

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux