On Thu, Aug 22, 2019 at 07:51:06AM +0200, Ahmad Fatoum wrote: > instr_param serves no purpose in the function. Thus remove it. > > Signed-off-by: Ahmad Fatoum <ahmad@xxxxxx> > --- > common/complete.c | 2 -- > include/ata_drive.h | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/common/complete.c b/common/complete.c > index 2dab7d1dde1e..919e5abc6a62 100644 > --- a/common/complete.c > +++ b/common/complete.c > @@ -277,7 +277,6 @@ static int env_param_complete(struct string_list *sl, char *instr, int eval) > struct device_d *dev; > struct variable_d *var; > struct env_context *c; > - char *instr_param; > int len; > char end = '=', *pos, *dot; > char *begin = ""; > @@ -317,7 +316,6 @@ static int env_param_complete(struct string_list *sl, char *instr, int eval) > > devname = xstrndup(instr, dot - instr); > > - instr_param++; > > dev = get_device_by_name(devname); > free(devname); > diff --git a/include/ata_drive.h b/include/ata_drive.h > index 11685eef12cf..d61c6f11d4d3 100644 > --- a/include/ata_drive.h > +++ b/include/ata_drive.h > @@ -14,7 +14,7 @@ > */ > > #ifndef ATA_DISK_H > -# define ATA_DISK > +#define ATA_DISK_H Unrelated change? Michael > > #include <block.h> > > @@ -197,4 +197,4 @@ struct device_d; > * 0x400 data data 16 bit area with 1 kiB in size > */ > > -#endif /* ATA_DISK */ > +#endif /* ATA_DISK_H */ > -- > 2.20.1 > > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
