Re: [PATCH v3 09/10] scripts: add nmon-loader

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 12 Aug 2019 09:41:21 +0200
Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:

> Hi Antony,
> 
> On Sun, Aug 11, 2019 at 12:59:05PM +0300, Antony Pavlov wrote:
> > On Tue, 18 Dec 2018 10:19:42 +0300
> > Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote:
> > 
> > Hi Sascha!
> > 
> > It looks like this patch is missed in the master branch.
> > Please apply the patch!
> 
> I was about to apply it when I just saw that neither the commit message
> nor a comment in the script give a hint what this all about. Could you
> add something?
> 
> > > +if {$argc != 3} {
> > > +    puts "Usage:"
> > > +    puts "    nmon-loader.expect <file> <device> <speed>"
> 
> The script is named just nmon-loader, not nmon-loader.expect.

Ok, I'll add a comment to the script itself and resend the updated patch.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux