Roland Hieber <rhi@xxxxxxxxxxxxxx> writes:
> On Mon, Aug 05, 2019 at 04:09:27PM +0200, Sascha Hauer wrote:
>> - if (caam_need_rng_software_selftest()) {
>> + if (!(rd_reg32(&ctrl->r4tst[0].rdsta) & RDSTA_IFMASK)) {
>
> I'm not sure if I would understand that condition some years later
> without a comment, but then I'm not very versed in the NXP CAAM and the
> rest of the code also does many things like that without explaining
> them, so I guess it's okay :D
>
> - Roland
Maybe:
/*
* According to 6.10.74.1 of the i.MX6UL Security Reference Manual,
* RDSTA_IF1 and RDSTA_IF2 (contained in RDSTA_IFMASK) are flags whether
* the state handles have been instantiated.
*/
We can probably run the self test a second time by skipping the
instantiation descriptors and only executing the self test sequence.
I don't know if thats really worth it though.
Regards,
Rouven Czerwinski
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
